chore(deps): update Native SDK to v0.14.0#5365
Open
github-actions[bot] wants to merge 1 commit intomainfrom
Open
chore(deps): update Native SDK to v0.14.0#5365github-actions[bot] wants to merge 1 commit intomainfrom
github-actions[bot] wants to merge 1 commit intomainfrom
Conversation
bruno-garcia
force-pushed
the
deps/scripts/update-sentry-native-ndk.sh
branch
from
6848c11 to
e6718b8
Compare
github-actions
Bot
added
the
dependencies
bruno-garcia
force-pushed
the
deps/scripts/update-sentry-native-ndk.sh
branch
from
e6718b8 to
3619d7f
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| retrofit = { module = "com.squareup.retrofit2:retrofit", version.ref = "retrofit" } | ||
| retrofit-gson = { module = "com.squareup.retrofit2:converter-gson", version.ref = "retrofit" } | ||
| sentry-native-ndk = { module = "io.sentry:sentry-native-ndk", version = "0.13.8" } | ||
| sentry-native-ndk = { module = "io.sentry:sentry-native-ndk", version = "0.14.0" } |
There was a problem hiding this comment.
Bug: The native layer does not respect the Java SDK's options.getMetrics().setEnabled(false) setting, causing metrics to be sent even when disabled.
Severity: MEDIUM
Suggested Fix
Update the SentryNdk.init() method to read the options.getMetrics().isEnabled() value from the Java options. Pass this boolean to the native layer during its initialization to ensure the native SDK's metrics configuration is synchronized with the Java SDK's setting.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: gradle/libs.versions.toml#L154
Potential issue: The Java SDK does not propagate the metrics enabled/disabled setting to
the native (NDK) layer. With the update to `sentry-native` SDK v0.14.0, which enables
metrics by default, users who disable metrics in the Java SDK via
`options.getMetrics().setEnabled(false)` will still have the native layer sending them.
The `SentryNdk.init()` method does not pass the Java-level setting to the `NdkOptions`,
causing the user's configuration to be ignored for native events.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps scripts/update-sentry-native-ndk.sh from 0.13.8 to 0.14.0.
Auto-generated by a dependency updater.
Changelog
0.14.0
Breaking / Important behavior changes:
0.13.5and is now documented as part of the0.14.0behavior. Applications that do not want to send metrics must explicitly opt out withsentry_options_set_enable_metrics(options, false). (#1609)0.13.9and is now documented as part of the0.14.0behavior. Applications that do not want to capture structured logs must explicitly opt out withsentry_options_set_enable_logs(options, false). (#1673)0.13.9
Features:
sentry_options_set_enable_logs(options, false). (#1673)crashpad_wait_for_uploadflag. (#1679, crashpad#152)sentry_options_set_enable_large_attachments. (#1545)Fixes:
shutdown_timeoutoption in the daemon. (#1691)